Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add common interface tools test #5815

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: add common interface tools test #5815

wants to merge 10 commits into from
+80 −0

Conversation

shulanbushangshu
Copy link
Contributor

Description

add common interface toold test

Tests performed

add common interface toold test

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Dec 8, 2023
@shulanbushangshu shulanbushangshu added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 8, 2023
isamu-takagi
isamu-takagi reviewed Dec 12, 2023
View reviewed changes
common/component_interface_tools/package.xml Outdated
<depend>tier4_system_msgs</depend>
<depend>yaml_cpp_vendor</depend>

<test_depend>ament_cmake_ros</test_depend>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package uses ament_cmake_auto, so ament_cmake_ros is not needed if you use ament_auto_add_gtest. instead of ament_add_ros_isolated_gtest.

common/component_interface_tools/test/test_service_log_checker.cpp Outdated
@@ -0,0 +1,63 @@
// Copyright 2023 TIER IV, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright 2023 TIER IV, Inc.
// Copyright 2023 The Autoware Contributors

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is updated and applied.

@stale Stale
Copy link

stale bot commented Feb 19, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Feb 19, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Dec 10, 2024

@shulanbushangshu could you rebase this to the latest main?

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Dec 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@shulanbushangshu shulanbushangshu force-pushed the comm_tools branch 7 times, most recently from b70046c to dd6dacc Compare December 17, 2024 01:38
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.30%. Comparing base (b3c69b4) to head (4b4f4a6).
Report is 233 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5815      +/-   ##
==========================================
- Coverage   28.33%   28.30%   -0.04%     
==========================================
  Files        1485     1484       -1     
  Lines      111092   111090       -2     
  Branches    43152    43166      +14     
==========================================
- Hits        31483    31449      -34     
- Misses      76588    76623      +35     
+ Partials     3021     3018       -3
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total ∅ <ø> (∅) Carriedforward from b3c69b4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shulanbushangshu
Copy link
Contributor Author

@shulanbushangshu could you rebase this to the latest main?

It is rebased

xmfcx
xmfcx requested changes Dec 18, 2024
View reviewed changes
common/autoware_component_interface_tools/package.xml
@@ -17,8 +18,17 @@
<depend>tier4_system_msgs</depend>
<depend>yaml_cpp_vendor</depend>

<test_depend>ament_cmake_ros</test_depend>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<test_depend>ament_cmake_ros</test_depend>
<test_depend>ament_cmake_ros</test_depend>

It seems that this is not required.

xmfcx
xmfcx reviewed Dec 18, 2024
View reviewed changes
common/autoware_component_interface_tools/test/test_autoware_component_interface_tools.cpp Outdated
// limitations under the License.
#include "service_log_checker.hpp"

#include <ament_index_cpp/get_package_share_directory.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include <ament_index_cpp/get_package_share_directory.hpp>

This is not used in the file.

xmfcx
xmfcx reviewed Dec 18, 2024
View reviewed changes
common/autoware_component_interface_tools/test/test_autoware_component_interface_tools.cpp Outdated
#include <rclcpp_components/register_node_macro.hpp>

#include <gtest/gtest.h>
#include <yaml-cpp/yaml.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include <yaml-cpp/yaml.h>

This is not used in the file.

xmfcx
xmfcx reviewed Dec 18, 2024
View reviewed changes
common/autoware_component_interface_tools/test/test_autoware_component_interface_tools.cpp Outdated

#include <ament_index_cpp/get_package_share_directory.hpp>
#include <rclcpp/node_options.hpp>
#include <rclcpp_components/register_node_macro.hpp>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include <rclcpp_components/register_node_macro.hpp>

This is not used in the file.

@shulanbushangshu
Copy link
Contributor Author

Remove the unused head file.@xmfcx

shulanbushangshu and others added 10 commits February 4, 2025 19:24
@shulanbushangshu @xmfcx
rebase commom tools
35d80de 
Signed-off-by: jack.song <jack.song@autocore.ai>
@shulanbushangshu @xmfcx
rebase commom tools
c5c53f8 
Signed-off-by: jack.song <jack.song@autocore.ai>
@shulanbushangshu @xmfcx
rebase commom tools
339bbc2 
Signed-off-by: jack.song <jack.song@autocore.ai>
@shulanbushangshu @xmfcx
rebase commom tools
0c137a5 
Signed-off-by: jack.song <jack.song@autocore.ai>
@shulanbushangshu @xmfcx
rebase commom tools
952e025 
Signed-off-by: jack.song <jack.song@autocore.ai>
@shulanbushangshu @xmfcx
rebase commom tools
1606290 
Signed-off-by: jack.song <jack.song@autocore.ai>
@shulanbushangshu @xmfcx
rebase commom tools
e2b7608 
Signed-off-by: jack.song <jack.song@autocore.ai>
@shulanbushangshu @xmfcx
rebase commom tools
a9e3874 
Signed-off-by: jack.song <jack.song@autocore.ai>
@shulanbushangshu @xmfcx
rebase commom tools
662e11a 
Signed-off-by: jack.song <jack.song@autocore.ai>
@pre-commit-ci @xmfcx
style(pre-commit): autofix
4b4f4a6
@stale Stale
Copy link

stale bot commented Apr 5, 2025

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Apr 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkhmy tkhmy Awaiting requested review from tkhmy

@yabuta yabuta Awaiting requested review from yabuta

@xmfcx xmfcx Awaiting requested review from xmfcx

@isamu-takagi isamu-takagi Awaiting requested review from isamu-takagi isamu-takagi is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) status:stale Inactive or outdated issues. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shulanbushangshu @xmfcx @isamu-takagi